Skip to content

Updating references to branch name master->main.#608

Merged
mum4k merged 4 commits intoenvoyproxy:mainfrom
mum4k:branch-rename
Jan 26, 2021
Merged

Updating references to branch name master->main.#608
mum4k merged 4 commits intoenvoyproxy:mainfrom
mum4k:branch-rename

Conversation

@mum4k
Copy link
Copy Markdown
Collaborator

@mum4k mum4k commented Jan 25, 2021

The branch was renamed recently for multiple repositories in the envoyproxy org.

Signed-off-by: Jakub Sobon mumak@google.com

The branch was renamed recently.

Signed-off-by: Jakub Sobon <mumak@google.com>
@mum4k mum4k added the waiting-for-review A PR waiting for a review. label Jan 25, 2021
@mum4k mum4k requested review from oschaaf and wjuan-AFK January 25, 2021 05:11
@mum4k
Copy link
Copy Markdown
Collaborator Author

mum4k commented Jan 25, 2021

@wjuan-AFK please review and assign back to me once done.

Signed-off-by: Jakub Sobon <mumak@google.com>
Copy link
Copy Markdown
Member

@oschaaf oschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Out of scope, but one fleeting thought is that it would be cool to have a small utility to check for dead links in scripts, code-level comments and documentation.

@oschaaf oschaaf removed the waiting-for-review A PR waiting for a review. label Jan 25, 2021
@wjuan-AFK
Copy link
Copy Markdown
Contributor

LGTM

@mum4k mum4k merged commit 9448036 into envoyproxy:main Jan 26, 2021
@mum4k mum4k deleted the branch-rename branch January 26, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants